Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

absolute sources behind "reverse proxy with subpath" does not work #934

Closed
4 tasks done
rodja opened this issue May 18, 2023 · 0 comments · Fixed by #1038
Closed
4 tasks done

absolute sources behind "reverse proxy with subpath" does not work #934

rodja opened this issue May 18, 2023 · 0 comments · Fixed by #1038
Assignees
@falkoschindler
Labels
bug Something isn't working
Milestone
1.2.22

Comments

@rodja
Copy link
Member

rodja commented May 18, 2023 •
edited by falkoschindler
Loading

Description

Similar to the fix in ui.link from #556 we need to make sure sources (for images, video, audio, ...) are taking path_prefix into account.

  • ui.interactive_image
  • ui.audio
  • ui.video
  • ui.image
@rodja rodja added the bug Something isn't working label May 18, 2023
@rodja rodja added this to the 1.2.15 milestone May 18, 2023
@rodja rodja changed the title image src behind "reverse proxy with subpath" does not work absolute image src behind "reverse proxy with subpath" does not work May 18, 2023
@rodja rodja changed the title absolute image src behind "reverse proxy with subpath" does not work absolute sources behind "reverse proxy with subpath" does not work May 19, 2023
@falkoschindler falkoschindler modified the milestones: 1.2.15, 1.2.16 May 26, 2023
@rodja rodja modified the milestones: 1.2.16, 1.2.17 May 31, 2023
@rodja rodja modified the milestones: 1.2.17, 1.2.18 Jun 5, 2023
@rodja rodja modified the milestones: 1.2.18, 1.2.19, 1.9.20 Jun 12, 2023
@falkoschindler falkoschindler linked a pull request Jun 16, 2023 that will close this issue
Sources behind proxy #934 #1038
Merged
@rodja rodja modified the milestones: 1.2.21, 1.2.22 Jun 17, 2023
rodja added a commit that referenced this issue Jun 18, 2023
@rodja
Merge pull request #1038 from zauberzeug/sources-behind-proxy
66f1b11 
Sources behind proxy #934
@rodja rodja mentioned this issue Aug 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@falkoschindler falkoschindler

Labels
bug Something isn't working
Projects
None yet
Milestone
1.2.22
Development

Successfully merging a pull request may close this issue.

Sources behind proxy #934 zauberzeug/nicegui
2 participants
@rodja @falkoschindler