Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example for NiceGUI with ROS2 #1059

Closed
wants to merge 8 commits into from
Closed

Conversation

JensOgorek
Copy link
Contributor

ROS2 examples with Docker functionality

@rodja rodja added the documentation Improvements or additions to documentation label Jun 23, 2023
@rodja
Copy link
Member

rodja commented Jun 23, 2023

The focus on just one example is great! Are the files in tests/ really necessary?

@falkoschindler
Copy link
Contributor

@rodja I think this is what ROS creates for you when creating a new node or package. But I'd vote for removing unnecessary files to reduce clutter and to focus on what is essential for this example. It's unlikely that anyone will miss them.

@falkoschindler falkoschindler changed the title adding two ros2 examples Example for NiceGUI with ROS2 Jun 23, 2023
@JensOgorek
Copy link
Contributor Author

Exactly, these files were created by ros2 pkg create --build-type ament_python. They are just some default tests.

@rodja
Copy link
Member

rodja commented Jun 24, 2023

I've tried running the turtlesim docker container on mac but there where errors with the xcb qt plugin. Even on Linux it's quite cumbersome to start the UI. Therefore I would favour a ROS2 example which only uses NiceGUI as a UI. That will be much simpler to start and use. Maybe build the turtlesim visualization directly with nicegui?

@JensOgorek
Copy link
Contributor Author

The reason for the xcb to error is the active OS. The configuration is for Ubuntu systems. You can start the Docker with docker compose up joystick_example to just run the joysick part. You can start the turtlesim locally and still use the joystick.
Also, I can look into creating multiple versions of the config for the different operating systems.
Getting the visualization out of the docker container is always cumbersome, that's just how docker is. Completely converting the turtlesim for this would defeat the purpose of using the turtlesim for this example, I think.

@rodja
Copy link
Member

rodja commented Jun 24, 2023

Completely converting the turtlesim for this would defeat the purpose of using the turtlesim for this example, I think.

I would sacrifice the turtlesim in favour of a simpler, easier demo which shows the advantages of NiceGUI over qt and similar solutions.

Getting the visualization out of the docker container is always cumbersome, that's just how docker is.

Exactly. That is one of the many advantages of using NiceGUI here...

@JensOgorek
Copy link
Contributor Author

JensOgorek commented Jun 24, 2023

I would sacrifice the turtlesim in favour of a simpler, easier demo which shows the advantages of NiceGUI over qt and similar solutions.

How about going back to minimal publisher with a custom message, that is put in with NiceGUI?

@rodja
Copy link
Member

rodja commented Jun 26, 2023

Closing in favour of #1083.

@rodja rodja closed this Jun 26, 2023
@falkoschindler falkoschindler added this to the 1.2.23 milestone Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants