Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow configuration of socket.io transport options #1262

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

rodja
Copy link
Member

@rodja rodja commented Jul 26, 2023

With this PR, nicegui.globals.socket_io_js_transports can be changed from the outside. With this it is for example possible to change the default communication from websocket to long polling. The PR does this for our hosted website, because fly.io requires a header to find the right instance which is only supported by browsers when using http polling, not websockets.

This will fix #1211 (see #1211 (comment) for details).

because fly.io requires a header to find the right instance
which is only supported by browsers with polling, not websockets
@rodja rodja added bug Something isn't working documentation Improvements or additions to documentation labels Jul 26, 2023
@rodja rodja added this to the 1.3.6 milestone Jul 26, 2023
@falkoschindler falkoschindler merged commit 2c53cf7 into main Jul 26, 2023
1 of 5 checks passed
@falkoschindler falkoschindler deleted the socketio_transports branch July 26, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

https://nicegui.io/ Automatically refresh without reason (with Safari)
2 participants