Disable default aggrid column fit

[qingant]

This is not desirable if you have a table with a big amount of columns. If you have 30+ columns, the column will be wrap and no header displayed.

We could control it by props but it might just work as expected in most of cases by simply disabling it.

[falkoschindler]

Thanks for the pull request, @qingant!
The auto-sizing of grid columns has caused quite some confusion in the past (e.g. #1121).
I still think for small grids it is a rather nice default behavior. And just to avoid breaking changes, I would keep it for now. But I took the opportunity to make it configurable. What do you think?

[qingant]

Thanks for the pull request, @qingant! The auto-sizing of grid columns has caused quite some confusion in the past (e.g. #1121). I still think for small grids it is a rather nice default behavior. And just to avoid breaking changes, I would keep it for now. But I took the opportunity to make it configurable. What do you think?

Sure, thanks for the context. I will working on making it configurable.

[falkoschindler]

@qingant Oh, I already added the parameter auto_size_columns: bool = True to make it configurable. I just wanted to hear your opinion, whether you agree with this solution.

[qingant]

@qingant Oh, I already added the parameter auto_size_columns: bool = True to make it configurable. I just wanted to hear your opinion, whether you agree with this solution.

Thanks ! didn't realize that when I replied. agreed this is a good solution which gives the user the option to enable/disable it.

BTW: I noticed that this has been approved, should I merge it or it's better to wait someone else to merge ? asking this question to make sure I will do it right in the future when I want to contribute to this repo.

[falkoschindler]

No worries, @qingant. I just merged it. (I think you don't have the permission to do so.)
Thanks again for your contribution! 🙂