Fixed chart events for new hierarchy #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh wow, thanks for spotting this, @natankeddem! I had a somewhat bad feeling about changing the class hierarchy, and that feeling proved to be right... 😣 @rodja Maybe we should create a bugfix release with this PR so that the newly announced point dragging feature is actually working. |
falkoschindler
approved these changes
Aug 18, 2023
|
Can't make an omelette without breaking a few eggs... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like there is a new hierarchy for events that I didn't account for in my original PR. I believe this small change is all that should be required to get events on the chart element working again.