Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the QTimeline element #1639

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Added the QTimeline element #1639

merged 2 commits into from
Sep 19, 2023

Conversation

alikalik9
Copy link
Contributor

QTimeline added into nicegui.elements.

This is my first commit on github ever, so please bear with me, if it's not done properly. I tried following the guideline, but it's a bit overwhelming if you never worked on a public repo before.

@falkoschindler
Copy link
Contributor

Thanks for this PR, @alikalik9!

I looked into it and did quite some changes:

  • We don't need a custom Vue component in this case. We can simply use q-timeline from Python and can remove the timeline.js file.
  • The docstring was at a strange place. It should be the first line of a class or function.
  • add_item wasn't implemented. But it's better anyway to add items (or "entries") via with expressions.
  • I don't know what _generate_id was supposed to do. It wasn't needed.

So I basically re-wrote the component, added a pytest and a demo for the documentation. I'm still glad you gave it a try and created this pull request. Now NiceGUI has one more useful feature. 🙂

@falkoschindler falkoschindler added this to the 1.3.15 milestone Sep 19, 2023
@falkoschindler falkoschindler added the enhancement New feature or request label Sep 19, 2023
@falkoschindler falkoschindler merged commit 7001914 into zauberzeug:main Sep 19, 2023
1 check passed
@falkoschindler falkoschindler removed their request for review September 19, 2023 14:38
@alikalik9
Copy link
Contributor Author

@falkoschindler Thank you for the feedback. I will closely examine the changes you made when I find the time, in order to learn from them. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants