Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

submit audio/video control PR #1741

Merged
merged 2 commits into from
Oct 4, 2023
Merged

submit audio/video control PR #1741

merged 2 commits into from
Oct 4, 2023

Conversation

wgong
Copy link
Contributor

@wgong wgong commented Oct 4, 2023 •
edited by falkoschindler
Loading

  1. add play/pause/seek controls for Audio/Video elements
  2. add demo to website

Feature request: #1636

@falkoschindler falkoschindler self-requested a review October 4, 2023 15:18
@falkoschindler falkoschindler added the enhancement New feature or request label Oct 4, 2023
@falkoschindler falkoschindler added this to the 1.3.16 milestone Oct 4, 2023
falkoschindler
falkoschindler approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@falkoschindler falkoschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this pull request, @wgong! It looks really nice. 🙂
I just simplified the demos a bit to focus on the new features and to make sure they are self-containing. Moving the URL into global scope would render a code snippet which is not executable.

@falkoschindler falkoschindler merged commit 503769b into zauberzeug:main Oct 4, 2023
1 check passed
@wgong
Copy link
Contributor Author

wgong commented Oct 4, 2023

@falkoschindler Thank you for the fix. Love to help, I also learned a lot via coding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falkoschindler falkoschindler falkoschindler approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.3.16
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wgong @falkoschindler