Fix #2469. #2499
Merged
Fix #2469. #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoa, I got a message from tests that test_page_title failed on Python 3.10. But I'm not sure if it's a problem with the code changes. Please take a closer look on your side. |
falkoschindler
approved these changes
Feb 4, 2024
There was a problem hiding this comment.
Thanks a lot for this neat solution, @me21!
I just made it a bit more conservative by checking if the object really can't be accessed. This way we don't blindly exclude all fields with the name "originalTarget".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter out originalTarget property in the event, because it's non-standard, exists in Firefox only and causes issues with stringifying the event. See #2469.