Fix order of removing elements when client disconnects #2603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falkoschindler
approved these changes
Feb 24, 2024
There was a problem hiding this comment.
Thanks a lot for this pull request, @Johannes-!
This one is hard to spot (I guess) and it took me a while to understand the problem. At first I thought the old code should work, because we're deleting from self.elements and not from elements. But both references could point to the same instance, so removing from self.elements is also removing from elements.
Long story short, your change looks absolutely correct. 👍🏻
falkoschindler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Issue #2589