Replace check_interval for JavaScript requests with asyncio event #2827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves one aspect of issue #2482 by replacing the 0.01s loop with asyncio events.
To verify everything is still working, I experimented with the following demo code:
Note that I didn't mark every single method parameter as DEPRECATED. I only marked the root implementation, which is called by all derived methods. Similarly, I only added a warning once. I even removed a duplicate marker and a warning for the deprecated
respond
parameter.