Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table cell slot without string template #3261

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

CrystalWindSnake
Copy link
Contributor

This PR is based on discussion #3148. The goal is to table cell slots without writing any Vue string templates.

@CrystalWindSnake
Copy link
Contributor Author

@falkoschindler Hi, I have already completed the basic functionality implementation. I will set aside time later to write tests and documentation. However, I encountered numerous challenges during the implementation process.

This is the basic flowchart.
image

  • to monitor the creation and destruction of slots, I created a new 'table_slot_placeholder' component. I'm not sure if there's a simpler approach to this.

  • the ValueElement components placed within Teleport must have their LOOPBACK attribute set to True. This is to ensure that the displayed values remain up-to-date when switching between table pages. I am unsure as to why is works.

@falkoschindler
Copy link
Contributor

Ok, thanks, @CrystalWindSnake! Just let me known when you think it's a good time for a first code review. 🙂

@CrystalWindSnake
Copy link
Contributor Author

Ok, thanks, @CrystalWindSnake! Just let me known when you think it's a good time for a first code review. 🙂

I've been quite busy with work recently, and I expect to need another two days to complete the unit tests. After that, I'll ask for your review, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants