New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better explanation of menu placement #541

Merged

rodja merged 1 commit into main from menu-docu

Mar 17, 2023

Member

rodja commented Mar 17, 2023

On Reddit we had a question regarding the alignment of menu items: https://www.reddit.com/r/nicegui/comments/11tbc1v/aligment_dropdown_menu/

It turns out that our documentation could be much more clear about the behaviour. This PR tries to fix that.


          better explanation of menu placement

fa51af2

rodja requested a review from falkoschindler

March 17, 2023 06:25

rodja added this to the v1.2.0 milestone

falkoschindler approved these changes

View reviewed changes

Contributor

falkoschindler left a comment

Interesting. I always put menu and trigger button side by side into a container. But using the button as container for the menu is a great idea. 👍

rodja merged commit b0f258c into main

falkoschindler deleted the menu-docu branch

March 17, 2023 07:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment