Fix pyinstaller packaging after introduction of "native" mode #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, the merging was accidental @falkoschindler. I discovered that packaging an app with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the introduction of native mode, frozen packages created with pyinstaller as described in https://nicegui.io/reference#package_for_installation produced an executable which hung in an endless restarting loop. After much analysis it seems to be caused by
https://github.com/zauberzeug/nicegui/blob/main/nicegui/native_mode.py#L15
After applying this PR, which enables freeze-support for multiprocessing the error is gone.