Fix highchart error on update before mounted. #581
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open the page: https://nicegui.io/reference#chart with your console opened.
You will see an error :
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'series')
This is because the chart.py component is updated without the vue component actually mounted yet, hence the chart does not exists and can be updated.
Plus, if the component unmount/remount on the life of a single page, the chart is therefore leaking. Added a destroy method to handle that.