Fix: Exception when closing native mode window on Windows #602
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #584 closing the webview window throws an
AttributeError
exception on Windows OS. This is caused byos.getpgid()
which only exists on unix systems.I replace the
os.kill(os.getpgid(os.getpid()), signal.SIGTERM)
method by_thread.interrupt_main()
.To avoid polling
is_set
, the blocking methodwait
is used to wait until theshutdown
event is triggered.