Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how settings are handled #21

Open
zaus opened this issue Sep 11, 2014 · 0 comments
Open

Improve how settings are handled #21

zaus opened this issue Sep 11, 2014 · 0 comments
Milestone

Comments

@zaus
Copy link
Owner

zaus commented Sep 11, 2014

Split 'settings' and 'services' to separate option fields, but include "optimized" form/service reference for faster checking (rather than looping all entries):

array( {form_plugin_prefix+form_id} => array( {list of services} ) )

Then we don't have to load all services until they're supposed to be used. Importance of this would be determined by results of analytics tracking in Issue #19.

Considered splitting up services into separate options (as they would if we go with Issue #20), but not sure how performant it is to fill the options table.

Refactor get_settings, get_services, save_settings, save_services. Consider adding validation filters (i.e. the list of allowed indexes to save), at least for settings.

@zaus zaus added this to the v2.0 milestone Sep 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant