Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get item list to product category (is product) page + pagination issue #126

Open
chomchuen opened this issue Feb 19, 2024 · 10 comments
Open
Assignees

Comments

@chomchuen
Copy link
Collaborator

1. Get item list to product category (is product) page

Current scenario.

  • Each item group button will show only if item that exactly = that item group name.
    (example: need to select item group = Electronic to display an item in Electronic page on Storefront)

However, item group is in the hierarchy structure so I need you to change condition to get the item to each item group on Storefront like the image below.

Image

Image

Electronic (parent) need to show all items from all child groups.
Phone/Accessory (child) show only items in there groups.


2. Pagination Issue

2.1 Product in Phone item group has 2 items but now 1st one is in the 1st page and 2nd is in the 4th page. So, move it to be in the same page.

Image
Image

2.2 All item counting, this number should be number of items in current item group not number of all products in the Store.

Image

@AnatholyB1
Copy link
Contributor

@the listing have to be done in three back end mot front end here, even when we sort by category, then we push back the chucked item list to the front sorted, and we change page on navigation we have to keep the same sorting

@AnatholyB1
Copy link
Contributor

@John-zaviago

@AnatholyB1
Copy link
Contributor

we have two options when we give the list of items to the front, we can get all items from the category selected and the items from its sub category, or give multiple category to the item on creation, like its category and all parents category then update the filter when we make the call. First option keeps the same data base architecture but second option seems more scalable for bigger call.

@John-zaviago
Copy link

@umer2001 - related to #77 please take over backend part.

@umer2001
Copy link
Collaborator

umer2001 commented Mar 5, 2024

@John-zaviago & @chomchuen

1. Get item list to product category (is product) page

Upon inspecting the webshop code, I got to know if we check the Include Descendants option that is available in Item Group doctype the problem related to Items of child Item groups not visible gets resolved.

Image

@chomchuen
Copy link
Collaborator Author

@umer2001 I've already checked this option, but it still doesn't work. The 'Electronic' (which is parent category) category isn't showing items in its child categories.

Do I need to wait you or Adam for fixing something else?
Image

@umer2001
Copy link
Collaborator

umer2001 commented Mar 5, 2024

@chomchuen , I have tested the API through Postman and it works, now need to check from the frontend code which I don't have the latest version!

@AnatholyB1 can you tell me where can I get the latest storefront code?

@AnatholyB1
Copy link
Contributor

so you hit webshop or e_commerce_store api ?

@AnatholyB1
Copy link
Contributor

if e_commerce_ctore, its in zaviago company

@AnatholyB1
Copy link
Contributor

if webshop ask @deviljutt to merge the code in the server -> app.hosting into the company repo @umer2001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants