Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings potentially override error state #138

Closed
uniqueg opened this issue Sep 5, 2023 · 0 comments · Fixed by #141
Closed

Warnings potentially override error state #138

uniqueg opened this issue Sep 5, 2023 · 0 comments · Fixed by #141

Comments

@uniqueg
Copy link
Member

uniqueg commented Sep 5, 2023

Currently, it is possible that the run state will be set to state RunStates.WARNING even though it was previously already set to RunStates.ERROR. However, an error state should always trump a warning state, which may be treated differently by downstream applications.

Therefore, it is necessary to ensure that the state has not been already changed from RunStates.OKAY before setting a warning state.

@uniqueg uniqueg mentioned this issue Sep 5, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant