-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infer polyA tail & Conda to Mamba #102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EDIT: Okay, I read the PR description :)
EDIT2: But PR #99 is closed, now I'm confused. In what order should PRs be merged? It would make sense to me to start with this one (after removing the polyA-related stuff).
Mamba changes look fine, but the PR still contains polyA changes. Is it supposed to be merged after the PR with those changes?
Not necessarily, it was intended in that order, but the previous PR contains just the subset of changes of this one. This branch was created from the polyA_tails branch so that when the polyA_tails is merged this one does not have any conflicts, but since the polyA is closed, you might as well just merge this one, which has both the CI as well as polyA changes. |
Yes, but that is the problem: the PR title and description does not reflect that! And so if I squash merge, there will be no entry in the history that will mention or describe the polyA tail code. And if I don't squash, we will get 7 commits for partial implementations, including a revert. What we want instead is two commits, one for the Mamba vs Conda change, the other for the polyA tail functionality. Two options here:
The second option is generally preferred because I can review independently. But in this case I'm fine with either. |
Yeah sure, I did not expect you would close the first one :D, will keep this in mind if I ever make two or more consecutive PRs in the future. I will go with rebase just to keep it simple for now. |
ddd08ce
to
ee40755
Compare
Oh, my bad, I misunderstood. Could have just reopened #99 then. |
Description
Fixes #86
Fixes #101
Type of change
Please delete options that are not relevant.
to not work as expected)
Checklist
Please carefully read these items and tick them off if the statements are true
or do not apply.
warnings
have added type annotations for any local variables that are non-trivial,
potentially ambiguous or might otherwise benefit from explicit typing.
methods/functions or updated previously existing ones
works
reduced the code coverage relative to the previous state
by the proposed changes
If for some reason you are unable to tick off all boxes, please leave a
comment explaining the issue you are facing so that we can work on it
together.