Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: wrap long line #112

Merged
merged 1 commit into from
Mar 28, 2023
Merged

refactor: wrap long line #112

merged 1 commit into from
Mar 28, 2023

Conversation

balajtimate
Copy link
Contributor

Description

This is a separate PR for the issue that flake8 found a line too long in get_read_layout.py.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

Please carefully read these items and tick them off if the statements are true
or do not apply.

  • I have performed a self-review of my own code
  • My code follows the existing coding style, lints and generates no new
    warnings
  • I have added type annotations to all function/method signatures, and I
    have added type annotations for any local variables that are non-trivial,
    potentially ambiguous or might otherwise benefit from explicit typing.
  • I have commented my code in hard-to-understand areas
  • I have added ["Google-style docstrings"] to all new modules, classes,
    methods/functions or updated previously existing ones
  • I have added tests that prove my fix is effective or that my feature
    works
  • New and existing unit tests pass locally with my changes and I have not
    reduced the code coverage relative to the previous state
  • I have updated any sections of the app's documentation that are affected
    by the proposed changes

If for some reason you are unable to tick off all boxes, please leave a
comment explaining the issue you are facing so that we can work on it
together.

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d95bfeb) 99.78% compared to head (fd4303f) 99.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #112   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          12       12           
  Lines         948      948           
=======================================
  Hits          946      946           
  Misses          2        2           
Impacted Files Coverage Δ
htsinfer/get_read_layout.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@uniqueg uniqueg changed the title fix: line too long refactor: wrap long line Mar 28, 2023
@uniqueg uniqueg merged commit 8b4deb4 into dev Mar 28, 2023
@uniqueg uniqueg deleted the read_layout_fix branch March 28, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants