-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: describe workflow rationale #135
base: dev
Are you sure you want to change the base?
Conversation
Merge with dev branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of issues, but shouldn't take long to fix. Didn't look at all of the many changes in the pipeline documentation file carefully - but it looks mostly fine :)
To be fair, it's probably one of the 10 most detailed pipeline documentations ever written 🤣
> Given the short length of the reads, the sequence similarity among miRNAs, | ||
> and the merging of two different mapping results, the number of hits can | ||
> be notably high. Therefore, reads aligned beyond a specified value are | ||
> disregarded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as in the other file applies.
> Given the short length of the reads, the sequence similarity among miRNAs, | ||
> and the merging of two different mapping results, the number of hits can | ||
> be notably high. Therefore, reads aligned beyond a specified value are | ||
> disregarded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as in the other file applies.
> Given the short length of the reads and the sequence similarity among miRNAs, | ||
> the number of hits can be notably high. Therefore, reads aligned beyond a | ||
> specified value are disregarded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as in the other file applies.
> Given the short length of the reads and the sequence similarity among miRNAs, | ||
> the number of hits can be notably high. Therefore, reads aligned beyond a | ||
> specified value are disregarded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as in the other file applies.
Oh, and please check why the static code analysis fails. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the open comments and send for re-review when you are done 🙏
This PR closes #126.
The changes applied are:
pipeline_documentation.md