Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update htsinfer_to_tsv.py with zarp-cli compatibilities #143

Merged
merged 1 commit into from
May 23, 2023

Conversation

balajtimate
Copy link
Contributor

[no ci]

Description

  • Replaced numpy's np.isnan() with pandas' pd.isna() in the should_i_flag() function in order to work with object or string datatypes
  • Added default = 0 to tparams["index_size"] = max([]) to set default if list is empty
  • Replaced organism name with taxon_id in jparams to have better (future) compatibility with zarp-cli

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Conventional Commits guidelines

Changes to workflow inputs (sample table and/or configs)

  • major (add BREAKING CHANGE: in the beginning of the PR title)
    • more fields/properties are required
    • existing ones are dropped entirely
  • minor (add feat: in the beginning of the PR title)
    • optional fields/properties are added
    • required ones are made optional

Changes to workflow outputs

  • major (add BREAKING CHANGE: in the beginning of the PR title)
    • changes lead to removal/change of existing outputs (format or location)
  • minor (add feat: in the beginning of the PR title)
    • additional outputs are generated
    • content (but not format or location) of existing outputs changes

Everything else: patch
(add any other conventional commit in the beginning of the PR title)

Checklist:

  • My code changes follow the style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have updated the project's documentation

@balajtimate balajtimate merged commit 27a07d9 into dev May 23, 2023
@balajtimate balajtimate deleted the fix_htsinfer_to_tsv branch May 23, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants