Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sent the file path in the load method instead in the loader constructor #23

Closed
zazoomauro opened this issue Feb 21, 2017 · 0 comments
Closed
Milestone

Comments

@zazoomauro
Copy link
Owner

zazoomauro commented Feb 21, 2017

Instead of loading the service configuration file in the FileLoader constructor load the file directly in the load method.

import {ContainerBuilder, YamlFileLoader} from 'node-dependency-injection'

let container = new ContainerBuilder()
let loader = new YamlFileLoader(container)
loader.load('services.yml')
  1. Deprecate the second parameter usage in the constructor. (throw a deprecated warning if the second parameter is sent)
  2. Enable an optional parameter in the load method (throw a deprecated warning if the parameter is not set)
@zazoomauro zazoomauro added this to the 1.5 milestone Feb 21, 2017
zazoomauro pushed a commit that referenced this issue Mar 5, 2017
zazoomauro added a commit that referenced this issue Mar 6, 2017
* resolves #28 Working with definitions

* resolves #23 Sent the file path in the load method instead in the loader constructor

* resolves #7 Property Injection

* resolves #6 Lazy service

* Fix standard

* fix changelog

* fix code coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant