Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date published #1513

Merged
merged 6 commits into from
Jun 3, 2024
Merged

Date published #1513

merged 6 commits into from
Jun 3, 2024

Conversation

giacomociti
Copy link
Contributor

should fix #1502

Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: 3fb4e00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@cube-creator/core-api Patch
@cube-creator/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.06%. Comparing base (4a9a139) to head (3fb4e00).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1513      +/-   ##
==========================================
+ Coverage   74.04%   74.06%   +0.01%     
==========================================
  Files         223      223              
  Lines       14994    15000       +6     
  Branches      838      837       -1     
==========================================
+ Hits        11103    11110       +7     
+ Misses       3882     3881       -1     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tpluscode tpluscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's important to add a test to the e2e run

.changeset/eighty-geckos-burn.md Outdated Show resolved Hide resolved
cli/lib/metadata.ts Outdated Show resolved Hide resolved
giacomociti and others added 2 commits May 15, 2024 12:51
Co-authored-by: Tomasz Pluskiewicz <tpluscode@users.noreply.github.com>
Co-authored-by: Tomasz Pluskiewicz <tpluscode@users.noreply.github.com>
@giacomociti
Copy link
Contributor Author

I think it's important to add a test to the e2e run

do you mean API or UI e2e test?

@tpluscode
Copy link
Collaborator

I think it's important to add a test to the e2e run

do you mean API or UI e2e test?

Neither. I meant the publish pipeline run in cli/test/lib/commands/publish.test.ts

@giacomociti giacomociti merged commit 6ea3bb1 into master Jun 3, 2024
19 checks passed
@giacomociti giacomociti deleted the datePublished branch June 3, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unexpectedly cubes with schema:version == 1 have schema:datePublished twice
2 participants