Include vocabs serialised as RDF/JS code in package #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please also update the changelog, and also add a few words about #73 in there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds build step to publish all vocabularies serialised using @rdfjs/serializer-rdfjs
Draft until a new version of the serialiser is published.
The packages are not committed but only serialised during
npm pack/npm publish. I thought to have them serialised on the client's machine instead but I find it rather troublesome. The serialiser generated TypeScript code to get proper typings so that would require a multistep process on the consumer end.An obvious drawback however is that the package will now double in size in
node_modules.