Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identical filter are only once allowed in the filter-container #32

Closed
l00mi opened this issue Sep 8, 2016 · 3 comments
Closed

identical filter are only once allowed in the filter-container #32

l00mi opened this issue Sep 8, 2016 · 3 comments

Comments

@l00mi
Copy link
Contributor

l00mi commented Sep 8, 2016

if the users does try to add the same filter again, please fire an event (ideally with the id or a uniquie way to select the already existing data-filter)

@bergos
Copy link
Contributor

bergos commented Sep 8, 2016

This commit add the app.events.filterDuplicate event, which forwards all the filter parameters.

@l00mi l00mi assigned l00mi and unassigned bergos Sep 12, 2016
@l00mi
Copy link
Contributor Author

l00mi commented Sep 12, 2016

implement a visual cue showing that the filter is already active. e.g. one of these:

  • short glowing of the active filter
  • shaking of the clicked button
  • not allowing to click at all (different style and no pointer cursor)

@l00mi
Copy link
Contributor Author

l00mi commented Feb 14, 2017

This issue was moved to zazuko/zack-search#12

@l00mi l00mi closed this as completed Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants