Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group the same filters (same predicate) in the filter-container #35

Closed
l00mi opened this issue Sep 12, 2016 · 2 comments
Closed

group the same filters (same predicate) in the filter-container #35

l00mi opened this issue Sep 12, 2016 · 2 comments
Assignees

Comments

@l00mi
Copy link
Contributor

l00mi commented Sep 12, 2016

Add the filters which are needed to groups (by adding them inside the same

<div class="filter-grouped" data-predicate=".."> ... </div>

which allows to show it visually.

@l00mi
Copy link
Contributor Author

l00mi commented Feb 6, 2017

@bergos I gave this some more thought. Finally I think we need to have a more general grouping.

Where the idea is every added filter is AND (so basically like now but instead of the same predicate group or (the IN construct) we go back to just having multiple ?s ?p ?o.).

And we give the ability to create arbitrary groups which will be handled as OR. I imagine that we can drop one filter onto the other or a existing group in the UI and a new group is created. Everything in a group is strictly OR, basically a set of FILTERS.

Sorry for the change in spirit. What do you think?

@l00mi
Copy link
Contributor Author

l00mi commented Feb 14, 2017

This issue was moved to zazuko/zack-search#9

@l00mi l00mi closed this as completed Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants