Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of Histogram not working after changing with the handles. #20

Open
l00mi opened this issue Feb 20, 2017 · 5 comments
Open

Update of Histogram not working after changing with the handles. #20

l00mi opened this issue Feb 20, 2017 · 5 comments
Assignees
Labels

Comments

@l00mi
Copy link
Contributor

l00mi commented Feb 20, 2017

No description provided.

@l00mi l00mi added the bug label Feb 20, 2017
@bergos
Copy link
Contributor

bergos commented Feb 23, 2017

Should be fixed with this commit.

@l00mi
Copy link
Contributor Author

l00mi commented Feb 23, 2017

hmm, i still experience the same effect, lets look at this together once?

@ktk
Copy link
Member

ktk commented Feb 23, 2017

Same here, can't really get it to work anymore

@bergos
Copy link
Contributor

bergos commented Feb 24, 2017

Sorry, not fixed, but now I'm sure it runs into the update code. I think it's a d3 problem. @l00mi can you have a look at it?

@bergos bergos assigned l00mi and unassigned bergos Feb 24, 2017
@l00mi l00mi added this to To Do in Histogram Redo Nov 20, 2017
@larsvers
Copy link
Contributor

We might want to look down this rabbit hole together. The (short) problem flow is as follows:

  1. histogram formulates query within brush, sending off the brushed dates
  2. query gets send (I guess triggered by the handle onchange?)
  3. response returns with different dates and respective bucket data.

All years are rounded to 1st of Jan (the brush usually returns second-precise dates), which is fine.
The date differences between queried dates and response dates are usually small when the brush appears before 1948.

However, any brush with a toHandle date beyond 1948 ends up either at 1948 (if the fromHandle date is before 1948) or with a toHandle date of 2000 or empty dates.

Some examples:

 Query: [Wed Feb 05 1862 21:54:00 GMT+0100 (CET), Tue May 06 1969 02:42:15 GMT+0200 (CEST)]
 Response: {start: Thu Jan 01 1863 01:00:00 GMT+0100 (CET), end: Thu Jan 01 1948 01:00:00 GMT+0100 (CET)}

 Query: [Fri Jul 03 1840 01:17:34 GMT+0200 (CEST), Thu Aug 01 1940 17:42:55 GMT+0200 (CEST)]
 Response: {start: Sun Jan 01 1837 01:00:00 GMT+0100 (CET), end: Sun Jan 01 1933 01:00:00 GMT+0100 (CET)}

 Query: [Sun Oct 04 1959 15:42:28 GMT+0200 (CEST), Wed Dec 26 1979 07:18:55 GMT+0100 (CET)]
 Response: {start: "", end: ""}

 Query: [Sun May 03 1959 17:51:43 GMT+0200 (CEST), Sat Jan 01 2000 01:00:00 GMT+0100 (CET)]
 Response: {start: Sat Jan 01 2000 01:00:00 GMT+0100 (CET), end: Sat Jan 01 2000 01:00:00 GMT+0100 (CET)}

 Query: [Tue May 15 1934 13:29:13 GMT+0200 (CEST), Sun Jun 06 1943 15:10:33 GMT+0200 (CEST)]
 Response: {start: Wed Jan 01 1941 01:00:00 GMT+0100 (CET), end: Thu Jan 01 1942 01:00:00 GMT+0100 (CET)}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

4 participants