Malformed Content-Type header #102

ivanghisleni · 2019-12-31T08:40:34Z

Hi,

We found some emails with malformed Content-Type header that generate crash:

In PartBuilder.php line 228:

   [Symfony\Component\Debug\Exception\UndefinedMethodException]
   Attempted to call an undefined method named "getValueFor" of class "ZBateso
   n\MailMimeParser\Header\GenericHeader".
   Did you mean to call "getValue"?


 Exception trace:
   at /var/www/esva/backend/vendor/zbateson/mail-mime-parser/src/Message/Part/PartBuilder.php:228
  ZBateson\MailMimeParser\Message\Part\PartBuilder->getMimeBoundary() at /var/www/esva/backend/vendor/zbateson/mail-mime-parser/src/Message/Part/PartBuilder.php:265
  ZBateson\MailMimeParser\Message\Part\PartBuilder->setEndBoundaryFound() at /var/www/esva/backend/vendor/zbateson/mail-mime-parser/src/Message/MessageParser.php:130
  ZBateson\MailMimeParser\Message\MessageParser->findContentBoundary() at /var/www/esva/backend/vendor/zbateson/mail-mime-parser/src/Message/MessageParser.php:187
  ZBateson\MailMimeParser\Message\MessageParser->readPartContent() at /var/www/esva/backend/vendor/zbateson/mail-mime-parser/src/Message/MessageParser.php:219
  ZBateson\MailMimeParser\Message\MessageParser->readPart() at /var/www/esva/backend/vendor/zbateson/mail-mime-parser/src/Message/MessageParser.php:238
  ZBateson\MailMimeParser\Message\MessageParser->read() at /var/www/esva/backend/vendor/zbateson/mail-mime-parser/src/Message/MessageParser.php:65
  ZBateson\MailMimeParser\Message\MessageParser->parse() at /var/www/esva/backend/vendor/zbateson/mail-mime-parser/src/MailMimeParser.php:70
  ZBateson\MailMimeParser\MailMimeParser->parse() at /var/www/esva/backend/src/LibraEsva/Archiver/Mail.php:193

Here the sample of portion of the EML that cause the issue:

="Content-Type: multipart/mixed;Boundary="USER_UNKNOWN"

The fix could be easy adding an extra check on contentType into getMimeBoundary():

/**
     * Returns the parsed boundary parameter of the Content-Type header if set
     * for a multipart message part.
     * 
     * @return string
     */
    public function getMimeBoundary()
    {
        if ($this->mimeBoundary === false) {
            $this->mimeBoundary = null;
            $contentType = $this->getContentType();
            if ($contentType !== null && $contentType instanceof ParameterHeader) {
                $this->mimeBoundary = $contentType->getValueFor('boundary');
            }
        }
        return $this->mimeBoundary;
    }

Does it make sense to create a pull request for fixing it?

The text was updated successfully, but these errors were encountered:

travisaustin · 2019-12-31T19:34:16Z

I'm seeing this, as well.

zbateson · 2020-01-02T03:34:22Z

Interesting, thanks for reporting.

It looks to me like the bug is that somehow HeaderFactory isn't returning a ParameterHeader for the Content-Type header, and that should be addressed rather than checking if the returned value is a ParameterHeader (the type should be a guarantee).

I'm confused about what's causing that in your example. Do you mean it's exactly like you pasted it with the leading =" or what's wrong with the header in your example that you think is causing this?

travisaustin · 2020-01-02T21:21:23Z

For me, the issue is occurring for a message that has a header called "contenttype".

I recognize that the contenttype header is not valid or correct, but I'd prefer the header be ignored instead of causing a fatal PHP error. :-)

Here's a complete message that causes this issue:

From: Test <test@test.com>
To: Test <test@test.com>
Subject: Test Message
Date: Thu, 2 Jan 2020 14:31:21 +0000
Message-ID: <test@test.com>
contenttype: text/html
Content-Type: multipart/alternative;
	boundary="_123_boundary_"
MIME-Version: 1.0

--_123_boundary_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Plaintext version

--_123_boundary_
Content-Type: text/html; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<html>
<head>
</head>
<body>
<p>HTML version</p>
</body>
</html>

--_123_boundary_--

ivanghisleni · 2020-01-04T16:25:48Z

Hi, I confirm you that the issue is related to =“ chars, I tried with the same eml without =“ and it worked ad expected. Inviato da iPhone

…

Il giorno 2 gen 2020, alle ore 04:34, Zaahid Bateson ***@***.***> ha scritto: Interesting, thanks for reporting. It looks to me like the bug is that somehow HeaderFactory isn't returning a ParameterHeader for the Content-Type header, and that should be addressed rather than checking if the returned value is a ParameterHeader (the type should be a guarantee). I'm confused about what's causing that in your example. Do you mean it's exactly like you pasted it with the leading =" or what's wrong with the header in your example that you think is causing this? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

zbateson · 2020-01-06T21:53:52Z

Thanks @travisaustin and @ivanghisleni -- both of those would be an issue but for slightly different reasons.

Unfortunately @travisaustin -- yours is a little more complicated. The reason is, in trying to make something like what's happening with @ivanghisleni work, I ended up treating both a header with a name like "contenttype" to be equal to one with a name like "content-type", and the fix for that will be a little more complicated.

I'll try get something out for both if possible, I'll need to investigate a bit more, but certainly the @ivanghisleni issue can be addressed more quickly.

All the best.

- Only use normalized header names when exact matches aren't available - Use normalized header naming both when determining the class to use for a header, and for finding headers

zbateson · 2020-01-09T04:59:30Z

Fix for both released in 1.2.0

ivanghisleni · 2020-01-09T08:13:38Z

Great news, thank you!!

…

On Thu, Jan 9, 2020 at 5:59 AM Zaahid Bateson ***@***.***> wrote: Fix for both released in 1.2.0 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#102?email_source=notifications&email_token=ABRMQMBIEWXXW6MCJPP7H6LQ42VLFA5CNFSM4KBTXG6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIO7A2Y#issuecomment-572387435>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABRMQMC23T4SZPNGJR43C2LQ42VLFANCNFSM4KBTXG6A> .

travisaustin · 2020-01-13T21:59:51Z

@zbateson - Thank you for the fast turnaround for this!!

zbateson added the bug label Jan 2, 2020

zbateson closed this as completed Jan 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Malformed Content-Type header #102

Malformed Content-Type header #102

ivanghisleni commented Dec 31, 2019

travisaustin commented Dec 31, 2019

zbateson commented Jan 2, 2020

travisaustin commented Jan 2, 2020 •

edited

Loading

ivanghisleni commented Jan 4, 2020 via email

zbateson commented Jan 6, 2020 •

edited

Loading

zbateson commented Jan 9, 2020

ivanghisleni commented Jan 9, 2020 via email

travisaustin commented Jan 13, 2020

Malformed Content-Type header #102

Malformed Content-Type header #102

Comments

ivanghisleni commented Dec 31, 2019

travisaustin commented Dec 31, 2019

zbateson commented Jan 2, 2020

travisaustin commented Jan 2, 2020 • edited Loading

ivanghisleni commented Jan 4, 2020 via email

zbateson commented Jan 6, 2020 • edited Loading

zbateson commented Jan 9, 2020

ivanghisleni commented Jan 9, 2020 via email

travisaustin commented Jan 13, 2020

travisaustin commented Jan 2, 2020 •

edited

Loading

zbateson commented Jan 6, 2020 •

edited

Loading