-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mail with image couldn't be parsed successfully #95
Comments
I was considering the existence of a "charset" attribute on a content-type header to be indicative that the content is not binary. I've added to that condition so a charset of "binary" is considered binary, but my guess is there may be other instances of this in the wild with other weird choices for charset. Anyway, I'll release that for you. Thanks for reporting :) |
Released in 1.1.7 |
Thank you for your quick reply, but I still get the same error ... :( |
Thanks for letting me know -- I've pushed a commit that should resolve this now, sorry about the back-and-forth there was a second part I missed. I'll wait for you to confirm it first before releasing if you can. Thanks |
With this change, it seems to work. Would you so kind as to release a new version, so I can use this improved version of your excellent parser. Thanks!! |
Excellent, re-released in 1.1.8. I'll close again, but feel free to comment/reopen if still an issue! |
The parsing of the attached .eml file (zip compressed so I could upload it) failed ... it seems to have something to do with the "Content-Type: image/png; charset=binary; name="logo.png"
Test.eml.zip
My source code for parsing the .eml file
The text was updated successfully, but these errors were encountered: