Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): esy-cmake->@revery/esy-cmake@0.3.5001 #1

Merged
merged 4 commits into from
Jun 27, 2020

Conversation

Et7f3
Copy link
Contributor

@Et7f3 Et7f3 commented Jun 5, 2020

No description provided.

@Et7f3 Et7f3 mentioned this pull request Jun 5, 2020
6 tasks
@zbaylin
Copy link
Owner

zbaylin commented Jun 5, 2020

Hmm on macOS I now get the error

In file included from /Users/zbaylin/Development/esy-astyle/mac/src/ASBeautifier.cpp:10:
In file included from /Users/zbaylin/Development/esy-astyle/mac/src/astyle.h:17:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/cassert:20:10: fatal error: 'assert.h' file not found
#include <assert.h>
         ^~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/astyle.dir/src/ASBeautifier.cpp.o] Error 1
make[1]: *** [CMakeFiles/astyle.dir/all] Error 2
make: *** [all] Error 2
error: command failed: 'bash' './esy/build.sh' (exited with 2)
esy-build-package: exiting with errors above...
error: build failed with exit code: 1

Unclear if that's related to the cmake change, though

@Et7f3
Copy link
Contributor Author

Et7f3 commented Jun 5, 2020

Can you test on master ? Because it works in revery-ci.

@zbaylin
Copy link
Owner

zbaylin commented Jun 5, 2020

You're right, something got messed up on master. Strange -- it builds fine in revery locally.

@Et7f3
Copy link
Contributor Author

Et7f3 commented Jun 6, 2020

master of revery or esy-astyle ? Have you a issue in building https://github.com/revery-ui/revery/tree/reduce-deps (we should obtain after merge)

@zbaylin
Copy link
Owner

zbaylin commented Jun 27, 2020

I should probably set up some CI for this. I can also transfer ownership to the Revery org if @bryphe thinks that would be a good idea and we could use the Azure pipelines setup there. But yeah I have no problem merging this in.

@zbaylin
Copy link
Owner

zbaylin commented Jun 27, 2020

I added a very basic CI implementation in #2, once that gets merged I'll merge up master here and if it passes I'll merge this 👍

@zbaylin zbaylin merged commit 4c98c48 into zbaylin:master Jun 27, 2020
@Et7f3 Et7f3 deleted the patch-1 branch June 28, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants