Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zebra does not recognize APT pinning #1464

Closed
lhvy opened this issue Jul 20, 2020 · 9 comments
Closed

Zebra does not recognize APT pinning #1464

lhvy opened this issue Jul 20, 2020 · 9 comments
Labels
bug Something isn't working medium Medium priority level. May not be fixed in the next beta but is still important. scheduled The fix or enhancement has been implemented and scheduled for the next release sources Issues pertaining to the Sources tab or the addition/deletion of sources

Comments

@lhvy
Copy link

lhvy commented Jul 20, 2020

Is your feature request related to a problem? Please describe.
This feature request is due to an issue where two tweaks with the same bundle identifier (e.g. one is a drop-in replacement for another) and Zebra tries to get you to update from one tweak to the other if the version is higher. Specifically, I am having this problem with preferenceloader as the Odyssey jailbreak uses preferenceloader by DHowett and Zebra tries to get me to "update" to Sam Bingner's version. I also can't differentiate between the two when searching as they have the same bundle identifier. (Although that is less of an issue as you can select which version to install.)

Describe the solution you'd like
The ability to hide tweaks updates for a specific repo so that I can hide updates from one repo but still see when the tweak is updated on a repo I want. (e.g. Hide preferenceloader updates from BigBoss repo but allow from Odyssey repo.)

Describe alternatives you've considered
I have tried using the current "hide updates" button. The problem is that it hides updates from all repos, meaning I don't know if an update comes out for the tweak on the correct repo.

Edit: I don't want this feature request to be specifically about PreferenceLoader but seeing as there was a comment asking about it (which has just vanished for me) I'll quickly explain. One version of PreferenceLoader is bundled in with Odyssey on the Odyssey repo. Sam Bingner's copy is on the BigBoss repo, which is a default repo on Sileo and helpful to have regardless of which jailbreak I use. Zebra thinks the version on BigBoss is newer and tries to update to it, but the version on the Odyssey is modified specifically for the Odyssey jailbreak and I would like to use that one.

@wstyres
Copy link
Member

wstyres commented Aug 6, 2020

I can see why this would be a useful feature but I don't think it is actually needed. It should be up to the repo maintainer to be able to specify that their package is higher than another (in this case, coolstar should be able to bump the version number on their package so that the package from BigBoss would never show up on Zebra or Sileo). I'll do a little more investigation to be sure I'm right but I think 2.2.4~coolstar2 (hosted on Odyssey's repo) is actually a lesser version than 2.2.4 (hosted on BigBoss) so that it will always show as an update as long as you have BigBoss added. Not sure why it was set up this way.

I'm not opposed to the feature but I will do a little more thinking before adding it. My main reservation at the moment is it might be confusing to a lot of users to use and the specific use case of it for these two packages is pretty small.

@wstyres
Copy link
Member

wstyres commented Aug 25, 2020

I looked into it a little more and it appears that Coolstar's repo has been APT pinned higher than BigBoss which Zebra is not recognizing. Pinning will be put on the list and added in a future version of Zebra and I think that this is the proper solution to the issue as opposed to a unique feature like this.

@wstyres wstyres added bug Something isn't working medium Medium priority level. May not be fixed in the next beta but is still important. sources Issues pertaining to the Sources tab or the addition/deletion of sources and removed suggestion labels Aug 25, 2020
@wstyres wstyres changed the title Option to Hide Updates for Individual Tweaks on Certain Repos Zebra does not recognize APT pinning Aug 25, 2020
@mwoolweaver
Copy link

sorry to come in kinda late but would it be possible to read pinning prefs from /etc/apt/preferences.d/?

@wstyres
Copy link
Member

wstyres commented Sep 14, 2020

Yes, fixing pinning would require reading from preferences.d

@absidue absidue added the scheduled The fix or enhancement has been implemented and scheduled for the next release label Oct 18, 2020
@wstyres wstyres added this to the 1.2 milestone Dec 13, 2020
@wstyres
Copy link
Member

wstyres commented Dec 19, 2020

The latest beta includes support for source pinning but it is still a beta feature and may not properly work yet. Try it out and let us know how it works.

@PoomSmart
Copy link
Member

@CookieCoder15 Any updates?

@lhvy
Copy link
Author

lhvy commented Dec 31, 2020

Ah sorry my iPhone is running stock iOS 14.2 right now so I can't test. If anyone else could test that would be great. In the meantime, I'll see if my old iPad is in a position to test but I don't think it is.

@mwoolweaver
Copy link

It's 2 am (TX) here but I will test on my 8 plus when the sun comes back up and I have gotten some sleep.

@wstyres wstyres closed this as completed Jan 9, 2021
@wstyres
Copy link
Member

wstyres commented Jan 9, 2021

Going to close this issue, if any individual issues come up with this later, feel free to file another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working medium Medium priority level. May not be fixed in the next beta but is still important. scheduled The fix or enhancement has been implemented and scheduled for the next release sources Issues pertaining to the Sources tab or the addition/deletion of sources
Projects
None yet
Development

No branches or pull requests

5 participants