Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accent color not applying #911

Closed
worldlydev opened this issue Feb 28, 2020 · 16 comments
Closed

Accent color not applying #911

worldlydev opened this issue Feb 28, 2020 · 16 comments
Assignees
Labels
bug Something isn't working low Low priority level. Might not fixed in the next beta but should be fixed before final release. scheduled The fix or enhancement has been implemented and scheduled for the next release
Milestone

Comments

@worldlydev
Copy link
Contributor

worldlydev commented Feb 28, 2020

Describe the bug
A clear and concise description of what the bug is.

Accent color not applying.

Screenshots
If applicable, add screenshots to help explain your problem.

Screenshots:
ADB54F04-D72E-4761-AB89-54DDB6E65859
6CAE69C5-F802-46BA-8B92-D78186C7ACF6
548D5298-7D66-45B6-84CF-56903A04C59B

Screen recording:
https://imgur.com/a/2qZcvRx

Device Information (please complete the following information):

  • iOS Version [e.g. 12.1.2 or 10.3.3]: 13.3
  • Zebra Version [e.g. 1.0~beta1 or beta1]: 1.1 beta 2
  • Device Type [e.g. iPhone or iPad]: iPhone 11 pro
  • Jailbreak Type [e.g. unc0ver, Chimera, checkra1n, etc.]: Unc0ver
@worldlydev worldlydev added the bug Something isn't working label Feb 28, 2020
@wstyres
Copy link
Member

wstyres commented Feb 28, 2020

White is the default tint color (when not using a custom accent color) for that progress bar

@wstyres wstyres added packages Issues pertaining to the Packages tab or package management low Low priority level. Might not fixed in the next beta but should be fixed before final release. console Issues pertaining to the Console view controller or package management search Issues pertaining to the Search tab or the searching of packages and removed packages Issues pertaining to the Packages tab or package management labels Feb 28, 2020
@worldlydev
Copy link
Contributor Author

worldlydev commented Feb 28, 2020

White is the default tint color (when not using a custom accent color) for that progress bar

I'm using the system colors. Shouldn't it be the system blue color then?

Plus the cursor is still pastel purple.

@wstyres
Copy link
Member

wstyres commented Feb 28, 2020

Just as the switches are not blue, that progress bar doesn't default to the blue tint color, I will fix the background of the button and the tint color for the search bar.

@worldlydev
Copy link
Contributor Author

worldlydev commented Feb 28, 2020

Just as the switches are not blue, that progress bar doesn't default to the blue tint color, I will fix the background of the button and the tint color for the search bar.

So the progress bar not defaulting to blue won't be changed?

Also the cursor thing isn't just in the search bar FYI. Don't know if you know or not 😅 also applies to other places. Like when typing in the add repo field.

@worldlydev
Copy link
Contributor Author

Also applies to the cancel button for the repo import view.

1A6DA09A-46A1-4E9F-9232-933D9918C3AA

@worldlydev
Copy link
Contributor Author

38B3FCCE-3585-4E68-8E6F-B84CEA94BA79

@rctfan929
Copy link

The background of the button adjusts correctly for all tints except for system default.

iPhone 6s iOS 12.4

@wstyres wstyres added this to the 1.1 milestone Mar 29, 2020
@PoomSmart PoomSmart added the scheduled The fix or enhancement has been implemented and scheduled for the next release label Apr 12, 2020
@worldlydev
Copy link
Contributor Author

worldlydev commented Apr 13, 2020

This issue isn't fixed in the latest beta. Zebra 1.1 ~ beta 5
Using the system accent color some UI elements are still pastel purple while others aren't colored at all.

Cursor
129AA4A5-88E0-4FB4-BE29-9CB85D0CD568
85B1DD40-287F-4630-8C15-945F00B7A8FF
Cancel button in source refresh view
AC2A7865-F28C-4E5E-BF7C-74E2E8AF6E2E
Console progress bar
3C0DC101-A3DE-4FD2-B0BD-76E3F52AE96B
Console respring and close Zebra button
9F4FBF3B-B5E0-43C6-8E9B-5FE9D4B29795
Buttons and loading bar in Webview (Reddit articles and links in package depiction page)
561F585F-AD76-4C37-BE1E-897BDA30EF52
64876CA4-F002-4BEF-A253-07E1B002BE56
Ok button in filters page
A2476191-FF77-4092-A97F-61B709BD23CA

@wstyres
Copy link
Member

wstyres commented Apr 13, 2020

Not sure why this was marked as scheduled, I did not fix the issues.

@wstyres wstyres removed the scheduled The fix or enhancement has been implemented and scheduled for the next release label Apr 13, 2020
@wstyres wstyres self-assigned this Apr 24, 2020
@wstyres
Copy link
Member

wstyres commented Apr 24, 2020

I went through and fixed all the ones I could see in the screenshots, the last three you posted seem to be blue already though I can't tell. Let me know when the next beta rolls around.

@wstyres wstyres added scheduled The fix or enhancement has been implemented and scheduled for the next release and removed console Issues pertaining to the Console view controller or package management search Issues pertaining to the Search tab or the searching of packages labels Apr 24, 2020
@wstyres
Copy link
Member

wstyres commented Apr 26, 2020

@worldlydev double check to make sure these issues aren't present anymore

@worldlydev
Copy link
Contributor Author

@worldlydev double check to make sure these issues aren't present anymore

The progress bar is white and unaccented, the close/respring button is now white instead of blank but is still not accented, and the cancel button in the source refresh view is white and unaccented.

B1592C60-0AB7-498C-8A83-0F461E7570F8
63AC1CED-35FB-4E8C-ADA3-B6AC1EF9B75C
BC50EB97-3CBA-421F-9D75-4EF992923A5A

@wstyres
Copy link
Member

wstyres commented Apr 26, 2020

Those buttons and the progress bar are to be tinted white when "Use System Accent Colors" is turned off. But I'll tint the cancel/complete button blue

@worldlydev
Copy link
Contributor Author

Those buttons and the progress bar are to be tinted white when "Use System Accent Colors" is turned off. But I'll tint the cancel/complete button blue

But I have use system accent colors turned on.

@eve0415
Copy link
Contributor

eve0415 commented Apr 27, 2020

Also me, using system color and darkmode (not pure dark mode)

@wstyres
Copy link
Member

wstyres commented Apr 27, 2020

Meant to say when turned off, progress bar and console bar buttons should be white. The button will be blue though.

@wstyres wstyres closed this as completed Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low Low priority level. Might not fixed in the next beta but should be fixed before final release. scheduled The fix or enhancement has been implemented and scheduled for the next release
Projects
None yet
Development

No branches or pull requests

5 participants