Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix subunits #18

Merged
merged 5 commits into from
Oct 28, 2022
Merged

fix subunits #18

merged 5 commits into from
Oct 28, 2022

Conversation

b4D8
Copy link
Contributor

@b4D8 b4D8 commented Oct 27, 2022

Following up for #15 .

@b4D8
Copy link
Contributor Author

b4D8 commented Oct 27, 2022 •
edited
Loading

Note that I added Eq on CurrencySymbol and ParseCurrencyError as recommended by clippy. Feel free to remove these.

Lots of edits because of cargo fmt.

@b4D8
Copy link
Contributor Author

b4D8 commented Oct 27, 2022

And here are the fixes for #16 and #17 (thought I would do 2 PR but those are based on the exponent data).

@zbrox
Copy link
Owner

zbrox commented Oct 28, 2022

Everything looks good to me

@zbrox zbrox merged commit 9fa89ff into zbrox:master Oct 28, 2022
This was referenced Oct 28, 2022
Closed
Closed
Closed
@b4D8 b4D8 deleted the subunits-fraction-fix branch October 29, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@b4D8 @zbrox