Feat #36 support map kind #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
- Coverage 90.70% 89.46% -1.25%
==========================================
Files 11 11
Lines 818 930 +112
==========================================
+ Hits 742 832 +90
- Misses 69 88 +19
- Partials 7 10 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zc2638
reviewed
Dec 4, 2023
| func TestDefineWithNewType(t *testing.T) { | ||
| v := define(PetCat{}) | ||
| b, _ := json.Marshal(v) | ||
| fmt.Printf("result:%v\n", string(b)) |
There was a problem hiding this comment.
Do not use fmt output, instead use the correct expect and actual values for comparison.
| // Example: | ||
| // t ==> *[]*Struct|Struct|*string|string | ||
| // p.GoType.Kind() ==> []*Struct|Struct|*string|string | ||
| if p.GoType.Kind() == reflect.Slice { |
There was a problem hiding this comment.
Is it a repeated judgment?
The outer switch has determined Slice.
Comment on lines
+227
to
+231
| schemaMap := map[string]string{ | ||
| "time.Time": "string", | ||
| "time.Duration": "integer", | ||
| "json.Number": "number", | ||
| } |
There was a problem hiding this comment.
It is recommended to put it in a global variable and reuse it.
|
map解析存在多2层以上嵌套问题，暂时不做pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
支持map类型解析