Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: Add cost model #225

Merged
merged 3 commits into from
May 18, 2021
Merged

examples: Add cost model #225

merged 3 commits into from
May 18, 2021

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Mar 2, 2021

Usage: cargo run --example cost-model -- --help

Closes #47.

@codecov-io
Copy link

codecov-io commented Mar 2, 2021

Codecov Report

Merging #225 (0acbbe1) into main (8122ef3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #225   +/-   ##
=======================================
  Coverage   81.54%   81.54%           
=======================================
  Files          43       43           
  Lines        4698     4698           
=======================================
  Hits         3831     3831           
  Misses        867      867           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8122ef3...0acbbe1. Read the comment docs.

@str4d str4d force-pushed the cost-model branch 2 times, most recently from 7e9335f to 84a2951 Compare March 2, 2021 22:16
@r3ld3v r3ld3v added this to the Core Sprint 2021-08 milestone Mar 2, 2021
str4d added a commit that referenced this pull request Mar 3, 2021
It is causing problems in (some) downstream crates, and we won't want
these annotations in the codebase anyway if a downstream crate is
collecting metrics. We'll be replacing this with the cost model binary
in #225 shortly.
@r3ld3v r3ld3v removed this from the Core Sprint 2021-12 milestone Apr 12, 2021
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. I think this is good enough to merge and we should refine it in follow-up PRs.

@str4d str4d marked this pull request as ready for review May 18, 2021 12:54
@str4d
Copy link
Contributor Author

str4d commented May 18, 2021

Agreed. I've opened #266 and #267 for the remaining work.

@str4d str4d added this to the Core Sprint 2021-18 milestone May 18, 2021
@str4d str4d merged commit c0e23e6 into main May 18, 2021
@str4d str4d deleted the cost-model branch May 18, 2021 14:19
han0110 pushed a commit to han0110/halo2 that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance modelling
4 participants