Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

halo2_proofs: change IPA check equation to match the book #502

Merged
merged 2 commits into from Feb 14, 2022
Merged

halo2_proofs: change IPA check equation to match the book #502

merged 2 commits into from Feb 14, 2022

Conversation

ebfull
Copy link
Contributor

@ebfull ebfull commented Feb 14, 2022

Closes #500

@ebfull
halo2_proofs: change IPA check equation to match the book
f2daf91 
The verifier's check in the inner product argument used to assume that the
G'_0 value had an additional (trivial) blinding factor term, which makes
it slightly easier to reason that it never is the point at infinity.
However, we never sample challenges that are zeroes (both for security
and completeness reasons) so this element would never be the point at
infinity anyway. Thus, we can simplify the check with the added benefit of
matching the book's description of the protocol.
daira
daira approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@daira daira left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK modulo @str4d's comment.

@str4d str4d added this to the Core Sprint 2022-04 milestone Feb 14, 2022
@str4d str4d added the M-verifier-compatibility This is a backwards-incompatible change to the verifier label Feb 14, 2022
str4d
str4d approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK modulo comment changes. I confirmed that this now matches the protocol document.

halo2_proofs/src/poly/commitment/verifier.rs Show resolved Hide resolved
halo2_proofs/src/poly/commitment/verifier.rs Outdated Show resolved Hide resolved
str4d
str4d approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK f2daf91

@ebfull ebfull merged commit 247cd62 into main Feb 14, 2022
@str4d str4d deleted the simplify-ipa-equation branch February 14, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira approved these changes

@str4d str4d str4d approved these changes

Assignees
No one assigned
Labels
M-verifier-compatibility This is a backwards-incompatible change to the verifier
Projects
None yet
Milestone
Core Sprint 2022-04
Development

Successfully merging this pull request may close these issues.

IPA check is needlessly complicated
3 participants
@ebfull @daira @str4d