PR fixes on documentation

zcash_primitives/CHANGELOG.md

@@ -56,13 +56,14 @@ and this library adheres to Rust's notion of
 - `impl From<TxId> for [u8; 32]`
 - Added feature `local-consensus` to crate `zcash_primitives`
   - Adds `pub mod local_consensus`
-  - `local_consensus::FullNodeParameters` adds functionality to refer to Full Node 
-  parameters that can be either (public) Consensus nodes like `Network::MainNetwork` or `Network::TestNetwork`, or a `Local(P)` with a set of Parameters `P`. `Regtest` 
-  is considered a `LocalConsensus`.
+  - `local_consensus::FullNodeParameters` adds functionality to refer to Full Node
+    parameters that can be either (public) Consensus nodes like `Network::MainNetwork`
+    or `Network::TestNetwork`, or a `Local(P)` with a set of Parameters `P`. `Regtest` 
+    is considered a `LocalConsensus`.
   - `zcash_primitives::local_consensus::LocalNetwork` provides a type for specifying 
-  network upgrade activation heights for a given `FullNodeParameters::Local(P)`
+    network upgrade activation heights for a given `FullNodeParameters::Local(P)`
   - `impl Parameters for LocalNetwork` that use provided activation heights and
-  default to `constants::regtest::` for everything else. 
+    defaults to `constants::regtest::` for everything else. 
 
 ### Changed
 - `zcash_primitives::transaction`:

zcash_primitives/src/local_consensus.rs

@@ -3,17 +3,12 @@ use crate::{
     constants,
 };
 
-/// Represents the Network Parameters of the Full Node the caller
-/// would be connecting to.
-/// `Consensus(Network::MainNetwork)` refers to a Zcash Full Node
-/// running on public Mainnet
-/// `Consensus(Network::TestNetwork)` refers to a Zcash Full Node
-/// running on public Testnet
-/// `Local(P)` can be used to define the consensus parameters of
-/// a local or non-public network like one or more nodes on
-/// `regtest` mode.
+/// Represents the Network Parameters of the Full Node the caller connects to.
 pub enum FullNodeParameters<P: Parameters> {
+    /// Variant indicating a Zcash Full Node running on public Mainnet or Testnet
     Consensus(Network),
+    /// The consensus parameters of a local or non-public network like one or more nodes
+    /// in `regtest` mode.
     Local(P),
 }
 
@@ -63,6 +58,17 @@ pub struct LocalNetwork {
     pub z_future: Option<BlockHeight>,
 }
 
+/// Parameters default implementation for `LocalNetwork`
+/// Important note:
+/// The following functions return `constants::regtest` values
+/// ```
+/// fn coin_type()
+/// fn address_network()
+/// fn hrp_sapling_extended_spending_key()
+/// fn hrp_sapling_extended_full_viewing_key()
+/// fn hrp_sapling_payment_address()
+/// fn b58_script_address_prefix()
+/// ```
 impl Parameters for LocalNetwork {
     fn activation_height(&self, nu: NetworkUpgrade) -> Option<BlockHeight> {
         match nu {