Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Edwards curve coordinate naming conventions in the code #275

Closed
str4d opened this issue Aug 21, 2020 · 0 comments · Fixed by #276
Closed

Fix Edwards curve coordinate naming conventions in the code #275

str4d opened this issue Aug 21, 2020 · 0 comments · Fixed by #276

Comments

@str4d
Copy link
Contributor

str4d commented Aug 21, 2020

In the original Jubjub implementation from sapling-crypto, the coordinates of affine Edwards points were labelled (x, y). However, the jubjub crate (which we switched to in #272) labels them as (u, v), as does the protocol spec. This has resulted in the codebase mixing conventions. We should clean up the codebase to refer consistently to (u, v).

@str4d str4d changed the title Fix curve coordinate conventions in the code Fix Edwards curve coordinate naming conventions in the code Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant