Migrate to bls12_381 and jubjub crates #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes tests to ensure that the new generator constants match the current zcash_primitives::JUBJUB generators.
Includes tests to ensure that the new generator constants match the current zcash_primitives::JUBJUB generators.
We now use the jubjub crate for this.
It is replaced by the bls12_381 crate.
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
==========================================
+ Coverage 64.95% 66.07% +1.12%
==========================================
Files 117 101 -16
Lines 16632 13215 -3417
==========================================
- Hits 10803 8732 -2071
+ Misses 5829 4483 -1346
Continue to review full report at Codecov.
|
daira
approved these changes
Aug 21, 2020
| /// the curve or in the prime-order subgroup. | ||
| /// | ||
| /// This should only be used for hard-coding constants (e.g. fixed generators); in all | ||
| /// other cases, use [`SubgroupPoint::from_bytes`] instead. |
There was a problem hiding this comment.
😿 that we can't use constant evaluation with reasonable compile times. Hopefully that will get better.
Failing that, is the initialization-time overhead of using from_bytes significant enough to worry about? I would be inclined to just use from_bytes.
The primitives are no longer generic over a curve; we hard-code Jubjub, so we know that the smallest u-coordinate that is not on the curve is 1.
str4d
force-pushed
the
migrate-to-bls12_381-jubjub-crates
branch
from
1280b3e
to
d15acf8
Compare
Likely left over from the Sapling audit.
ebfull
approved these changes
Aug 21, 2020
Merged
|
Post-hoc ACK of the last 5 commits. The (x, y) -> (u, v) renames (and some missing renames to cmu) were done in #276. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #170. Closes #171.