Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TestConstraintSystem out of sapling-crypto #55

Closed
str4d opened this issue Jan 15, 2019 · 2 comments · Fixed by #104
Closed

Move TestConstraintSystem out of sapling-crypto #55

str4d opened this issue Jan 15, 2019 · 2 comments · Fixed by #104
Labels
E-good-first-issue Effort: Suitable for someone new to the codebase.

Comments

@str4d
Copy link
Contributor

str4d commented Jan 15, 2019

TestConstraintSystem is a useful module for testing circuit code, that currently lives inside the sapling-crypto crate alongside the Sprout and Sapling circuits. It should be moved somewhere that is obviously part of the toolkit for circuit implementers.

This will probably be a new crate that depends on bellman (given that @ebfull wants bellman to be flexible enough that such things don't need to be declared or maintained by bellman itself).

Part of #41.

@str4d str4d added the E-good-first-issue Effort: Suitable for someone new to the codebase. label Jan 15, 2019
@str4d
Copy link
Contributor Author

str4d commented Jan 15, 2019

Maybe a new crate named bellman_toolkit or bellman_testing?

@str4d
Copy link
Contributor Author

str4d commented Aug 14, 2019

#104 moves TestConstraintSystem into the gadgets module of bellman. This is sufficient for now; additional refactoring can happen when bellman itself is refactored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-good-first-issue Effort: Suitable for someone new to the codebase.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant