Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement std::fmt::Display for FsBlockDbError #742

Closed
pacu opened this issue Dec 13, 2022 · 0 comments · Fixed by #747
Closed

Implement std::fmt::Display for FsBlockDbError #742

pacu opened this issue Dec 13, 2022 · 0 comments · Fixed by #747

Comments

@pacu
Copy link
Contributor

pacu commented Dec 13, 2022

We need to implement a comprehensive set of errors for the FFI layer.

  Err(e) => Err(format_err!("Error while scanning blocks: {}", e)),
     |                                                                          ^ `FsBlockDbError` cannot be formatted with the default formatter
     |
     = help: the trait `std::fmt::Display` is not implemented for `FsBlockDbError`
@pacu pacu mentioned this issue Dec 28, 2022
Merged
pacu added a commit that referenced this issue Jan 2, 2023
@pacu
Implements fmt::Display descriptions for FsBlockDbError
3a323c4 
Closes #742

Fix clippy errors

PR Suggestions. Make Displayed error messaged more readable to users

Revert clippy fixes in favor of rustfmt rules
pacu added a commit that referenced this issue Jan 3, 2023
@pacu
Implements fmt::Display descriptions for FsBlockDbError
015a585 
Closes #742

Fix clippy errors

PR Suggestions. Make Displayed error messaged more readable to users

Revert clippy fixes in favor of rustfmt rules

Commit suggestion on `InvalidBlockstoreRoot`

Co-authored-by: str4d <jack@electriccoin.co>

PR Suggestion `MissingBlockPath`

Co-authored-by: str4d <jack@electriccoin.co>

PR Suggestion `InvalidBlockPath`

Co-authored-by: str4d <jack@electriccoin.co>

Run cargo fmt and fix issues
@str4d str4d closed this as completed in #747 Jan 4, 2023
@str4d str4d reopened this Jan 25, 2023
@str4d str4d closed this as completed Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement fmt::Display descriptions for FsBlockDbError zcash/librustzcash
2 participants
@pacu @str4d