-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove notices about the BOSL license #1071
Conversation
6358a62
to
6a020df
Compare
6a020df
to
c7b0f3d
Compare
c7b0f3d
to
a0bea05
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1071 +/- ##
=======================================
Coverage 66.17% 66.17%
=======================================
Files 114 114
Lines 11063 11063
=======================================
Hits 7321 7321
Misses 3742 3742 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM. However, I double-checked, and in main
we currently patch in zcash/orchard@1892573 which is the tip of a branch that does not include the license change. Its child merge commit zcash/orchard@ba70c32 does include the license change. If we wait until #1108 merges then this PR's changes will be correct.
#1108 has merged, so this can now be rebased. |
…needed. Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
a0bea05
to
76f9226
Compare
fixes #1072