Remove ff::PrimeFieldRepr #223

str4d · 2020-04-23T06:06:49Z

Closes #159.

…for_scalar

Adapted from Scalar::non_adjacent_form in curve25519-dalek.

The trait is implemented by default for u8 and u64, allowing pow_vartime to be used with both the byte encoding and limb representation of field elements.

This enables BitIterator to be used with both the byte encoding and limb representation of scalars.

The ff::PrimeField::Repr associated type now has the minimal necessary bounds, which can be satisfied by a newtype around a byte array.

codecov · 2020-04-23T06:36:18Z

Codecov Report

Merging #223 into master will increase coverage by 14.25%.
The diff coverage is 59.19%.

@@             Coverage Diff             @@
##           master     #223       +/-   ##
===========================================
+ Coverage   51.08%   65.34%   +14.25%     
===========================================
  Files          99      106        +7     
  Lines       13318    15041     +1723     
===========================================
+ Hits         6804     9828     +3024     
+ Misses       6514     5213     -1301

Impacted Files	Coverage Δ
bellman/src/domain.rs	`63.58% <ø> (+63.58%)`	⬆️
bellman/src/gadgets/multieq.rs	`50.00% <ø> (-45.24%)`	⬇️
ff/ff_derive/src/lib.rs	`19.60% <0.00%> (ø)`
group/src/lib.rs	`11.76% <0.00%> (+11.76%)`	⬆️
pairing/src/bls12_381/fq2.rs	`61.77% <0.00%> (+61.77%)`	⬆️
pairing/src/bls12_381/mod.rs	`61.49% <0.00%> (+61.49%)`	⬆️
pairing/src/tests/engine.rs	`100.00% <ø> (ø)`
bellman/src/groth16/tests/dummy_engine.rs	`7.47% <14.28%> (+7.47%)`	⬆️
zcash_primitives/src/primitives.rs	`47.32% <33.33%> (-46.91%)`	⬇️
zcash_primitives/src/sapling.rs	`83.87% <33.33%> (-16.13%)`	⬇️
... and 135 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97c21e0...49f119f. Read the comment docs.

ebfull · 2020-04-30T20:20:02Z

ACK though there's some more API fiddling I'd like to do, we can do it later.

str4d added 9 commits March 26, 2020 19:00

group: Take scalar by reference in CurveProjective::recommended_wnaf_…

6e53cf3

…for_scalar

group: Rewrite wNAF to remove dependency on ff::PrimeFieldRepr

69c6053

Adapted from Scalar::non_adjacent_form in curve25519-dalek.

ff: Move pow_vartime into a trait that is generic over the limb size

b6457a9

The trait is implemented by default for u8 and u64, allowing pow_vartime to be used with both the byte encoding and limb representation of field elements.

ff: Add PrimeField: From<u64> constraint

fd79de5

ff: Rework BitIterator to work with both u8 and u64 limb sizes

232f0a5

This enables BitIterator to be used with both the byte encoding and limb representation of scalars.

ff: PrimeField::{is_even, is_odd}

1fdca39

ff: PrimeField: BitAnd<u64, Output = u64> + Shr<u32, Output = Self>

08500ee

zcash_primitives: Make jubjub::Fs::invert constant time

1a40cfd

ff: Add Ord bound to PrimeField

1fe3e37

str4d added the S-scratching-an-itch Status: Something we haven't planned for a sprint but are doing anyway label Apr 23, 2020

str4d requested a review from ebfull April 23, 2020 06:06

ff: Remove PrimeFieldRepr trait

49f119f

The ff::PrimeField::Repr associated type now has the minimal necessary bounds, which can be satisfied by a newtype around a byte array.

str4d force-pushed the remove-primefieldrepr branch from 1c2b203 to 49f119f Compare April 23, 2020 06:15

This was referenced Apr 24, 2020

Overhaul traits zkcrypto/ff#16

Open

Fixed 'PrimeField' docstrings zkcrypto/ff#11

Closed

enabling zeroize for field elements zkcrypto/ff#22

Closed

str4d merged commit b02cf3b into zcash:master Apr 30, 2020

ebfull mentioned this pull request Apr 30, 2020

Sapling Implementation Refactor #41

Closed

18 tasks

str4d added this to the Core Sprint 2020-17 milestone Apr 30, 2020

str4d deleted the remove-primefieldrepr branch September 26, 2020 19:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove ff::PrimeFieldRepr #223

Remove ff::PrimeFieldRepr #223

str4d commented Apr 23, 2020

codecov bot commented Apr 23, 2020 •

edited

Loading

ebfull commented Apr 30, 2020

Remove ff::PrimeFieldRepr #223

Remove ff::PrimeFieldRepr #223

Conversation

str4d commented Apr 23, 2020

codecov bot commented Apr 23, 2020 • edited Loading

Codecov Report

ebfull commented Apr 30, 2020

codecov bot commented Apr 23, 2020 •

edited

Loading