Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZIP 339 support #424

Merged
merged 1 commit into from
Aug 12, 2021
Merged

ZIP 339 support #424

merged 1 commit into from
Aug 12, 2021

Conversation

daira
Copy link
Contributor

@daira daira commented Aug 7, 2021

Signed-off-by: Daira Hopwood daira@jacaranda.org

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@daira daira mentioned this pull request Aug 7, 2021
@codecov
Copy link

codecov bot commented Aug 7, 2021

Codecov Report

Merging #424 (d1443e5) into master (1a40fc9) will decrease coverage by 0.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
- Coverage   61.14%   60.75%   -0.40%     
==========================================
  Files          88       88              
  Lines        8568     8518      -50     
==========================================
- Hits         5239     5175      -64     
- Misses       3329     3343      +14     
Impacted Files Coverage Δ
zcash_client_backend/src/data_api/wallet.rs 76.47% <0.00%> (-6.87%) ⬇️
zcash_client_backend/src/data_api/chain.rs 80.00% <0.00%> (-4.91%) ⬇️
zcash_client_backend/src/proto.rs 42.50% <0.00%> (-2.50%) ⬇️
...h_primitives/src/transaction/components/sapling.rs 71.67% <0.00%> (-2.47%) ⬇️
zcash_proofs/src/circuit/ecc.rs 79.75% <0.00%> (-2.34%) ⬇️
zcash_primitives/src/transaction/txid.rs 75.64% <0.00%> (-1.96%) ⬇️
zcash_primitives/src/transaction/components/tze.rs 30.13% <0.00%> (-1.37%) ⬇️
zcash_client_sqlite/src/wallet.rs 78.14% <0.00%> (-1.34%) ⬇️
...ponents/zcash_address/src/kind/unified/f4jumble.rs 60.78% <0.00%> (-1.22%) ⬇️
components/zcash_note_encryption/src/lib.rs 67.81% <0.00%> (-1.15%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a40fc9...d1443e5. Read the comment docs.

@daira daira marked this pull request as ready for review August 12, 2021 07:17
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@nuttycom nuttycom merged commit 98dc330 into zcash:master Aug 12, 2021
@r3ld3v r3ld3v added this to the Core Sprint 2021-30 milestone Aug 13, 2021
@daira daira deleted the zip339-primitives branch August 13, 2021 20:03
daira added a commit to daira/zcash that referenced this pull request Aug 13, 2021
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
zkbot added a commit to zcash/zcash that referenced this pull request Aug 13, 2021
ZIP 339 support

Depends on zcash/librustzcash#424 .

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
str4d pushed a commit to daira/zcash that referenced this pull request Aug 19, 2021
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
zkbot added a commit to zcash/zcash that referenced this pull request Aug 19, 2021
ZIP 339 support

Depends on zcash/librustzcash#424 .

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
zkbot added a commit to zcash/zcash that referenced this pull request Aug 23, 2021
ZIP 339 support

Depends on zcash/librustzcash#424 .

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants