Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sapling address encodings #88

Merged
merged 6 commits into from
Jul 10, 2019
Merged

Sapling address encodings #88

merged 6 commits into from
Jul 10, 2019

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Jun 27, 2019

The zip32 crate is also converted into a module of zcash_primitives.

@str4d str4d requested review from daira, ebfull and Eirik0 June 27, 2019 15:25
daira
daira approved these changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, a pleasure to read! ut(ACK+cov)

@str4d str4d merged commit 91c6b0b into zcash:master Jul 10, 2019
@str4d str4d deleted the address-encodings branch July 10, 2019 11:04
@ebfull ebfull mentioned this pull request Jul 10, 2019
Closed
18 tasks
@str4d str4d added this to the v0.1.0 milestone Aug 22, 2019
@str4d str4d mentioned this pull request Jan 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira approved these changes

@ebfull ebfull ebfull approved these changes

@Eirik0 Eirik0 Awaiting requested review from Eirik0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@str4d @daira @ebfull