Bigint arithmetic #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| template<mp_size_t n> template<mp_size_t m> | ||
| inline bigint<n+m> bigint<n>::operator*(const bigint<m>& other) const | ||
| { | ||
| static_assert(n >= m, "first arg must not be smaller than second arg for bigint mul"); |
There was a problem hiding this comment.
See the documentation of mpn_mul at https://gmplib.org/manual/Low_002dlevel-Functions.html . I thought it was weird too, but didn't want to add the complexity of swapping the arguments when necessary.
|
ACK no blockers. Awesome work! |
|
Can this be rebased onto zcash/libsnark's master so that the zcash PR is solid? |
…comparison. Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
daira
force-pushed
the
bigint-arithmetic
branch
from
937ddc2
to
d65904a
Compare
|
Rebased. |
zkbot
pushed a commit
to zcash/zcash
that referenced
this pull request
Aug 23, 2016
Implement zkSNARK compression Implement zkSNARK compression. The serialization format of zkSNARKs has now been specified in our protocol specification. G1/G2 elements are now compressed into 33 byte and 65 byte formats, repsectively. `MONTGOMERY_OUTPUT` is enabled everywhere to make proving/verifying keys load faster and be consistent with the MPC. Proofs are now 296 bytes. This PR also updates the proving and verifying keys. Closes #1103. Closes #471. See also zcash/libsnark#3 and zcash/libsnark#4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for bigint addition, multiplication, quotient+remainder, and comparison.