Improve 64-bit to 32-bit limb conversion #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code base is now on Rust 1.56 and Rust edition 2021. As per zcash#31 (comment) the code can now be simplified. This commit is also adding a test for the u64_to_u32 function.
Codecov ReportBase: 68.89% // Head: 69.25% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
==========================================
+ Coverage 68.89% 69.25% +0.36%
==========================================
Files 11 11
Lines 1212 1210 -2
==========================================
+ Hits 835 838 +3
+ Misses 377 372 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code base is now on Rust 1.56 and Rust edition 2021. As per #31 (comment) the code can now be simplified. This commit is also adding a test for the u64_to_u32 function.
I've based it on
main, but I'll happily rebase once other PRs are merged first.