Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate extended RPC tests to Zcash #2530

Open
str4d opened this issue Jul 13, 2017 · 1 comment
Open

Migrate extended RPC tests to Zcash #2530

str4d opened this issue Jul 13, 2017 · 1 comment
Labels
A-rpc-interface Area: RPC interface A-testing Area: Tests and testing infrastructure C-cleanup Category: PRs that clean code up or issues documenting cleanup. C-tech-debt Category: Technical debt that needs to be paid off L-python Involves Python code. special to Daira
Projects
Security and Stability Encouraged Community Work

Comments

@str4d
Copy link
Contributor

str4d commented Jul 13, 2017 •
edited by daira

The extended RPC tests (so-designated by upstream because they were too resource-heavy to run on CI) have never been run by us and therefore never migrated to Zcash. We should migrate

One of the motivations for me is that amongst the P2P/Net upstream PRs are some that add regular RPC tests which utilise the MiniNode - a Python half-node inside the test suite which has never been migrated to Zcash (as until now it was only used in extended RPC tests), and therefore does not run.
@str4d str4d added the A-testing Area: Tests and testing infrastructure label Jul 13, 2017
@daira daira added C-cleanup Category: PRs that clean code up or issues documenting cleanup. special to Daira labels Jul 13, 2017
@str4d str4d mentioned this issue Jul 13, 2017
Merged
zkbot added a commit that referenced this issue Oct 5, 2017
@zkbot
Auto merge of #2533 - str4d:2530-mininode, r=<try>
6c8687a 
Migrate MiniNode to Zcash

This enables various RPC tests that use it (most of them in the extended test suite) to properly test Zcash code.

The PR also fixes bugs in the BIP65 and BIP66 tests that were both masking and masked by the un-migrated MiniNode.

The Python module `pyblake2` is now a requirement for the RPC tests.

Part of #2530.
zkbot added a commit that referenced this issue Oct 16, 2017
@zkbot
Auto merge of #2533 - str4d:2530-mininode, r=str4d
a2dc9be 
Migrate MiniNode to Zcash

This enables various RPC tests that use it (most of them in the extended test suite) to properly test Zcash code.

The PR also fixes bugs in the BIP65 and BIP66 tests that were both masking and masked by the un-migrated MiniNode.

The Python module `pyblake2` is now a requirement for the RPC tests.

Part of #2530.
@daira daira added this to Discussion in Security and Stability Nov 11, 2017
@daira daira added the L-python Involves Python code. label Jan 27, 2019
@daira daira added the C-tech-debt Category: Technical debt that needs to be paid off label Apr 5, 2019
@daira daira added this to Needs Prioritization in Arborist Team via automation Apr 5, 2019
@daira daira added the A-rpc-interface Area: RPC interface label Apr 5, 2019
@daira
Copy link
Contributor

daira commented Apr 5, 2019

The MiniNode was migrated in #2533. I don't know what the remaining blockers are for fixing the extended RPC tests.

@mms710 mms710 added this to Needs Prioritization in Encouraged Community Work via automation Apr 11, 2019
@mms710 mms710 removed this from Needs Prioritization in Arborist Team Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rpc-interface Area: RPC interface A-testing Area: Tests and testing infrastructure C-cleanup Category: PRs that clean code up or issues documenting cleanup. C-tech-debt Category: Technical debt that needs to be paid off L-python Involves Python code. special to Daira
Projects
Encouraged Community Work
  
Needs Prioritization
Security and Stability
  
Discussion
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daira @str4d