Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename all gtest test case names and test names to use CamelCase #3575

Closed
str4d opened this issue Oct 8, 2018 · 7 comments · Fixed by #4258
Closed

Rename all gtest test case names and test names to use CamelCase #3575

str4d opened this issue Oct 8, 2018 · 7 comments · Fixed by #4258
Labels
A-testing Area: Tests and testing infrastructure C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-good-first-issue Effort: Suitable for someone new to the codebase. M-has-pr To-be-removed (GitHub has linked:pr filter)

Comments

@str4d
Copy link
Contributor

str4d commented Oct 8, 2018

https://github.com/google/googletest/blob/master/googletest/docs/faq.md#why-should-test-case-names-and-test-names-not-contain-underscore
@str4d str4d added A-testing Area: Tests and testing infrastructure C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-good-first-issue Effort: Suitable for someone new to the codebase. labels Oct 8, 2018
@str4d str4d mentioned this issue Oct 8, 2018
Merged
@bovem
Copy link
Contributor

bovem commented Oct 8, 2018

@str4d I would like to work on this one

@str4d
Copy link
Contributor Author

str4d commented Oct 8, 2018

@avnish98 go ahead! 😃

@bovem
Copy link
Contributor

bovem commented Oct 8, 2018 •
edited
Loading

@str4d Thanks, I cannot find zcash-gtest file, am I looking for wrong file? can you tell me where I should look for gtest?

@str4d
Copy link
Contributor Author

str4d commented Oct 8, 2018

The relevant files are in src/gtest and src/wallet/gtest. Any TEST(foo_test_case, bar_test) line in any file in those folders should be rewritten as TEST(FooTestCase, BarTest).

@bovem
Copy link
Contributor

bovem commented Oct 9, 2018

@str4d Thanks

@Eirik0
Copy link
Contributor

Eirik0 commented Jun 13, 2019

Here is the PR for this #3583

@rex4539
Copy link
Contributor

rex4539 commented Nov 29, 2019

By the way, there is a duplicate issue #1324 that can be closed.

@daira daira mentioned this issue Dec 1, 2019
Closed
@daira daira added the M-has-pr To-be-removed (GitHub has linked:pr filter) label Dec 1, 2019
@oxarbitrage oxarbitrage mentioned this issue Dec 11, 2019
Merged
@zkbot zkbot closed this as completed in e105764 Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testing Area: Tests and testing infrastructure C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-good-first-issue Effort: Suitable for someone new to the codebase. M-has-pr To-be-removed (GitHub has linked:pr filter)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changing gtest to CamelCase oxarbitrage/zcash
5 participants
@rex4539 @daira @str4d @Eirik0 @bovem